feat: add organism selector to ga2 landing page #863
Conversation
Smeds
force-pushed
the
840-ga2-add-organism-selector-to-landing-page
branch
from
b3ee343 to
8e3fcdd
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds an organism selector component to the GA2 landing page, enabling users to browse assemblies by taxonomic lineage through an interactive sunburst visualization.
- Integrates taxonomy tree data into site configurations for both GA2 and BRC Analytics
- Adds a new SectionAssemblies component with sunburst visualization to the GA2 home page
- Updates data loading to use configuration-based taxonomy tree data instead of direct imports
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| site-config/ga2/local/config.ts | Adds taxonomy tree data import and configuration parameter |
| site-config/common/entities.ts | Extends AppSiteConfig interface with optional taxTree property |
| site-config/brc-analytics/local/config.ts | Adds taxonomy tree data import and configuration parameter |
| app/views/HomeView/ga2/homeView.tsx | Integrates SectionAssemblies component into home page layout |
| app/components/Home/components/Section/components/ga2/SectionAssemblies/sectionAssemblies.tsx | Creates new section component for browsing assemblies |
| app/components/Home/components/Section/components/ga2/SectionAssemblies/sectionAssemblies.styles.ts | Defines styling for the assemblies section |
| app/components/Home/components/Section/components/SectionViz/sunburst.tsx | Fixes useEffect dependency array to include all dependencies |
| app/components/Home/components/Section/components/SectionViz/data.ts | Updates data loading to use configuration-based approach with fallback |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } from "../../../app/apis/catalog/ga2/entities"; | ||
| import { AppSiteConfig } from "../../common/entities"; | ||
| import { APP_KEYS } from "../../common/constants"; | ||
| import data from "catalog/ga2/output/ncbi-taxa-tree.json"; |
There was a problem hiding this comment.
The import path uses a relative module resolution that may not be portable. Consider using an absolute import path or ensure this path is properly configured in your module resolution settings.
| import data from "catalog/ga2/output/ncbi-taxa-tree.json"; | |
| import data from "../../../catalog/ga2/output/ncbi-taxa-tree.json"; |
| import { FILTER_SORT } from "@databiosphere/findable-ui/lib/common/filters/sort/config/types"; | ||
| import { AppSiteConfig } from "../../common/entities"; | ||
| import { APP_KEYS } from "../../common/constants"; | ||
| import data from "catalog/output/ncbi-taxa-tree.json"; |
There was a problem hiding this comment.
The import path uses a relative module resolution that may not be portable. Consider using an absolute import path or ensure this path is properly configured in your module resolution settings.
| import data from "catalog/output/ncbi-taxa-tree.json"; | |
| import data from "../../../catalog/output/ncbi-taxa-tree.json"; |
| export function getData(): TaxonomyNode { | ||
| // Any data massaging can be done at this extension point. | ||
| return data; | ||
| const { taxTree } = config(); | ||
| if (!taxTree) { | ||
| return { | ||
| assembly_count: 0, | ||
| children: [], | ||
| name: "root", | ||
| ncbi_tax_id: "", | ||
| }; |
There was a problem hiding this comment.
The hardcoded fallback object should be extracted to a constant to improve maintainability and ensure consistency if this fallback is needed elsewhere.
github-project-automation
bot
moved this from Read For Review
to Done
in GA2 Development Tasks
github-project-automation
bot
moved this from Ready for Review
to Done
in BRC development tasks
Description
This will add the organism selector to the landing page of GA2, making this pull-request dependent on #854 .
Related Issue
#840